Am 17.10.2018 um 16:33 hat Alberto Garcia geschrieben: > The blkverify mode of Quorum can only be enabled if the number of > children is exactly two and the value of vote-threshold is also two. > > If the user tries to enable it but the other settings are incorrect > then QEMU simply prints an error message to stderr and carries on > disabling the blkverify setting. > > This patch makes quorum_open() fail and return an error in this case. > > Signed-off-by: Alberto Garcia <[email protected]> > Reported-by: Markus Armbruster <[email protected]>
While reviewing this, I think I found another problem: Shouldn't .bdrv_add_child refuse to add a child if s->is_blkverify == true? (And probably assert in .bdrv_del_child that s->is_blkverify == false after checking s->num_children <= s->threshold) Kevin
