On Fri, 19 Sept 2025 at 12:54, Daniel P. Berrangé <[email protected]> wrote: > > From: Vladimir Sementsov-Ogievskiy <[email protected]> > > Instead of open-coded g_unix_set_fd_nonblocking() calls, use > QEMU wrapper qemu_set_blocking(). > > Reviewed-by: Daniel P. Berrangé <[email protected]> > Signed-off-by: Vladimir Sementsov-Ogievskiy <[email protected]> > [DB: fix missing closing ) in tap-bsd.c, remove now unused GError var] > Signed-off-by: Daniel P. Berrangé <[email protected]> > ---
> index fe4be6be17..e83e6c6ee9 100644 > --- a/hw/misc/ivshmem-flat.c > +++ b/hw/misc/ivshmem-flat.c > @@ -154,7 +154,8 @@ static void ivshmem_flat_add_vector(IvshmemFTState *s, > IvshmemPeer *peer, > * peer. > */ > peer->vector[peer->vector_counter].id = peer->vector_counter; > - g_unix_set_fd_nonblocking(vector_fd, true, NULL); > + /* WARNING: qemu_socket_set_nonblock() return code ignored */ > + qemu_set_blocking(vector_fd, false, &error_warn); > > event_notifier_init_fd(&peer->vector[peer->vector_counter].event_notifier, > vector_fd); What is this WARNING comment intended to mean? Is it a TODO/bug ? (Coverity has just flagged this up (CID 1630446) for failing to check the return value from qemu_set_blocking().) thanks -- PMM
