The 'notifier' field name will be confusing when the BlockBackend attach and detach notifiers are added in the next commit. Rename the field so it's clear that this is the RAMBlock notifier.
Signed-off-by: Stefan Hajnoczi <[email protected]> Reviewed-by: Eric Blake <[email protected]> --- include/system/block-ram-registrar.h | 2 +- block/block-ram-registrar.c | 14 ++++++++------ 2 files changed, 9 insertions(+), 7 deletions(-) diff --git a/include/system/block-ram-registrar.h b/include/system/block-ram-registrar.h index d8b2f7942b..76c157bd54 100644 --- a/include/system/block-ram-registrar.h +++ b/include/system/block-ram-registrar.h @@ -21,7 +21,7 @@ */ typedef struct { BlockBackend *blk; - RAMBlockNotifier notifier; + RAMBlockNotifier ram_block_notifier; bool ok; } BlockRAMRegistrar; diff --git a/block/block-ram-registrar.c b/block/block-ram-registrar.c index fcda2b86af..d5b84667a1 100644 --- a/block/block-ram-registrar.c +++ b/block/block-ram-registrar.c @@ -12,7 +12,8 @@ static void ram_block_added(RAMBlockNotifier *n, void *host, size_t size, size_t max_size) { - BlockRAMRegistrar *r = container_of(n, BlockRAMRegistrar, notifier); + BlockRAMRegistrar *r = + container_of(n, BlockRAMRegistrar, ram_block_notifier); Error *err = NULL; if (!r->ok) { @@ -21,7 +22,7 @@ static void ram_block_added(RAMBlockNotifier *n, void *host, size_t size, if (!blk_register_buf(r->blk, host, max_size, &err)) { error_report_err(err); - ram_block_notifier_remove(&r->notifier); + ram_block_notifier_remove(n); r->ok = false; } } @@ -29,14 +30,15 @@ static void ram_block_added(RAMBlockNotifier *n, void *host, size_t size, static void ram_block_removed(RAMBlockNotifier *n, void *host, size_t size, size_t max_size) { - BlockRAMRegistrar *r = container_of(n, BlockRAMRegistrar, notifier); + BlockRAMRegistrar *r = + container_of(n, BlockRAMRegistrar, ram_block_notifier); blk_unregister_buf(r->blk, host, max_size); } void blk_ram_registrar_init(BlockRAMRegistrar *r, BlockBackend *blk) { r->blk = blk; - r->notifier = (RAMBlockNotifier){ + r->ram_block_notifier = (RAMBlockNotifier){ .ram_block_added = ram_block_added, .ram_block_removed = ram_block_removed, @@ -47,12 +49,12 @@ void blk_ram_registrar_init(BlockRAMRegistrar *r, BlockBackend *blk) }; r->ok = true; - ram_block_notifier_add(&r->notifier); + ram_block_notifier_add(&r->ram_block_notifier); } void blk_ram_registrar_destroy(BlockRAMRegistrar *r) { if (r->ok) { - ram_block_notifier_remove(&r->notifier); + ram_block_notifier_remove(&r->ram_block_notifier); } } -- 2.51.0
