On 10.09.25 12:41, Daniel P. Berrangé wrote:
On Tue, Sep 09, 2025 at 11:19:39AM +0300, Vladimir Sementsov-Ogievskiy wrote:
On 09.09.25 01:16, Peter Xu wrote:
On Wed, Sep 03, 2025 at 12:44:04PM +0300, Vladimir Sementsov-Ogievskiy wrote:
Use common qemu_set_blocking() instead.
Signed-off-by: Vladimir Sementsov-Ogievskiy <[email protected]>
Posix's qemu_socket_set_nonblock() asserts the retval.. While Windows's one
doesn't. IIUC that's the only reason you provided the generic error
path in all callers, just in case some of them might fail on Windows?
Honestly, I thought that checking error on Linux is good too.. It may fail,
why not to check, where possible?
Yep, it diagnoses the case where the FD might be invalid, or where
QEMU might not have access to it. This could potentially avoid killing
the VM if a FD was passed to QEMU over monitor that had access limited
by SELinux.
Good reason! I'll add it commit msg.
--
Best regards,
Vladimir
