On Tue, Sep 2, 2025, 12:54 PM Daniel P. Berrangé <[email protected]> wrote:
> On Mon, Sep 01, 2025 at 04:26:42PM -0400, John Snow wrote: > > RFC: Should I squash the last two backport patches? One technically > > introduces a regression which breaks our "no regressions in series" > > rule, but makes the per-patch relationship murkier. Please let me know. > > What is the effect of the regression ? > > If someone is running 'make check' (or a variant thereof), through > a "git bisect" will this regression be significant enough to break > their git bisect ? > It could, yes. To avoid it I need to squash the latest get_event_loop change in to the second-to-last one. I guess I'll just notate that it's cherry-picked from two commits and include both commit messages. Does that sound OK? (I've never really "cherry picked" across repositories like this where the file paths do not actually match, so it's been a bit of a manual affair.) > > With regards, > Daniel > -- > |: https://berrange.com -o- > https://www.flickr.com/photos/dberrange :| > |: https://libvirt.org -o- > https://fstop138.berrange.com :| > |: https://entangle-photo.org -o- > https://www.instagram.com/dberrange :| > >
