On 11/27/2017 1:04 AM, Nick Coghlan wrote:
On 27 November 2017 at 15:04, Greg Ewing <greg.ew...@canterbury.ac.nz> wrote:
Nick Coghlan wrote:

Perhaps the check could be:

   (type(lhs) == type(rhs) or fields(lhs) == fields(rhs)) and all
(individual fields match)


I think the types should *always* have to match, or at least
one should be a subclass of the other. Consider:

@dataclass
class Point3d:
     x: float
     y: float
     z: float

@dataclass
class Vector3d:
     x: float
     y: float
     z: float

Points and vectors are different things, and they should never
compare equal, even if they have the same field names and values.

And I guess if folks actually want more permissive structure-based
matching, that's one of the features that collections.namedtuple
offers that data classes don't.

And in this case you could also do:
astuple(point) == astuple(vector)

Eric.

_______________________________________________
Python-Dev mailing list
Python-Dev@python.org
https://mail.python.org/mailman/listinfo/python-dev
Unsubscribe: 
https://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com

Reply via email to