On Sep 11, 2017, at 18:36, Eric V. Smith <e...@trueblade.com> wrote: > So if we don't do enums, I think the choices are ints, strs, or maybe > True/False/None. Do you have a preference here? > > If int or str, I assume we'd want module-level constants. > > I like the name compare=, and 3 values makes sense: None, Equality, Ordered.
+1 for the name, the 3 values, and making them module constants. After that, I don’t think it really matters what their implementation is. User code will look the same either way. One minor nice effect of using an enum is that the dataclass function can use `is` instead of `==` to compare keyword argument values. -Barry
signature.asc
Description: Message signed with OpenPGP
_______________________________________________ Python-Dev mailing list Python-Dev@python.org https://mail.python.org/mailman/listinfo/python-dev Unsubscribe: https://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
