On Tue, Jul 7, 2015 at 3:08 PM, Serhiy Storchaka <storch...@gmail.com> wrote: > On 07.07.15 15:32, Maciej Fijalkowski wrote: >> >> I kind of thought that python does pre-commit reviews (at least seems >> to apply to most people), so in case someone is completely exempt from >> that, maybe he should read python-dev or wherever the reply is set to? >> That also does not explain why a crashing commit has not been >> reverted. > > > There is no haste. Only developed branch is affected and we have enough time > to fix it. No buildbots is broken. Just rolling back this changeset can be > impossible because Raymond committed other changes after it. I'm not sure > that this changeset is culprit, it can be previous one. Raymond is the most > experienced person in this file, and writing good fix that conform to > Raymond's view by other person can take more time than the time that is > needed to Raymond to awake and read this topic.
Then maybe a good option would be to add the crasher to the test suite, so the buildbots *are* actually broken showing the problem exists? _______________________________________________ Python-Dev mailing list Python-Dev@python.org https://mail.python.org/mailman/listinfo/python-dev Unsubscribe: https://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
