Thanks! All suggestions applied to my local copy. On Fri, Mar 6, 2015 at 1:55 PM Ethan Furman <et...@stoneleaf.us> wrote:
> On 03/06/2015 08:34 AM, Brett Cannon wrote: > > Over on the import-sig I proposed eliminating the concept of .pyo files > since they only signify that /some/ optimization > > took place, not /what/ optimizations took place. Everyone on the SIG was > positive with the idea so I wrote a PEP, got > > positive feedback from the SIG again, and so now I present to you PEP > 488 for discussion. > > +1 overall, comments in-line. > > > Implementation > > ============== > > > > importlib > > --------- > > > > As ``importlib.util.cache_from_source()`` is the API that exposes > > bytecode file paths as while as being directly used by importlib, it > > requires the most critical change. > > Not sure what that sentence is supposed to say -- maybe "as well as" and > not "as while as" ? > > > > The ``debug_override`` parameter will be deprecated. As the parameter > > expects a boolean, the integer value of the boolean will be used as > > if it had been provided as the argument to ``optimization`` (a > > ``None`` argument will mean the same as for ``optimization``). A > > deprecation warning will be raised when ``debug_override`` is given a > > value other than ``None``, but there are no plans for the complete > > removal of the parameter as this time (but removal will be no later > > than Python 4). > > "at this time" not "as this time" > > > > Rest of the standard library > > ---------------------------- > > > > The various functions exposed by the ``py_compile`` and > > ``compileall`` functions will be updated as necessary to make sure > > they follow the new bytecode file name semantics [6]_, [1]_. The CLI > > for the ``compileall`` module will not be directly affected (the > > ``-b`` flag will be implicitly as it will no longer generate ``.pyo`` > > files when ``-O`` is specified). > > "will be implicit" not "will be implicitly" > > -- > ~Ethan~ > > _______________________________________________ > Python-Dev mailing list > Python-Dev@python.org > https://mail.python.org/mailman/listinfo/python-dev > Unsubscribe: https://mail.python.org/mailman/options/python-dev/ > brett%40python.org >
_______________________________________________ Python-Dev mailing list Python-Dev@python.org https://mail.python.org/mailman/listinfo/python-dev Unsubscribe: https://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
