On Wed, 27 Jul 2011 02:25:56 +0200
senthil.kumaran <python-check...@python.org> wrote:
>
> + def test_sites_no_connection_close(self):
> + # Some sites do not send Connection: close header.
> + # Verify that those work properly. (#issue12576)
> +
> + try:
> + with urllib.request.urlopen('http://www.imdb.com') as res:
> + pass
Can you please at least use support.transient_internet() as in other
tests in this file?
> + except ValueError as e:
> + self.fail("urlopen failed for sites not sending
> Connection:close")
> + else:
> + self.assertTrue(res)
> +
> + req = urllib.request.urlopen('http://www.imdb.com')
Why a second time?
> + res = req.read()
> + self.assertTrue(res)
Also, when does "req" get closed? Right now I get resource warnings:
test_sites_no_connection_close (test.test_urllib2net.OtherNetworkTests) ...
/home/antoine/cpython/default/Lib/socket.py:342: ResourceWarning: unclosed
<socket.socket object, fd=3, family=2, type=1, proto=6>
self._sock = None
/home/antoine/cpython/default/Lib/socket.py:342: ResourceWarning: unclosed
<socket.socket object, fd=3, family=2, type=1, proto=6>
self._sock = None
ok
Regards
Antoine.
_______________________________________________
Python-Dev mailing list
Python-Dev@python.org
http://mail.python.org/mailman/listinfo/python-dev
Unsubscribe:
http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
