Am 26.03.2011 20:00, schrieb Terry Reedy: > On 3/26/2011 2:17 PM, Georg Brandl wrote: >> "Refactor" doesn't sound like it belongs in the 3.1 branch... > >>> - for i in range(len(pattern)): >>> - c = pattern[i] >>> + for i, c in enumerate(pattern): > > I would call thin 'Replace obsolete idiom in' rather than 'Refactor'. > So are you criticizing the replacement or the mislabeling?
No - I believe he is critizing that a stylistic change is done in a maintenance branch. It's not a bug fix, AFAICT, so it should not have been done. Regards, Martin P.S. I haven't looked into the specific context, but the diff alone may actually cause behavior changes, depending on what pattern exactly is. _______________________________________________ Python-Dev mailing list Python-Dev@python.org http://mail.python.org/mailman/listinfo/python-dev Unsubscribe: http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
