Ulrich Eckhardt wrote:
Hi!

I'm looking at trunk/Python/sysmodule.c, function PySys_SetArgv(). In that function, there is code like this:

  PyObject* path = PySys_GetObject("path");
  ...
  if (path != NULL) {
    ...
  }

My intuition says that if path==NULL, something is very wrong. At least I would expect to get 'None', but never NULL, except when out of memory. So, for the case that path==NULL', I would simply invoke Py_FatalError("no mem for sys.path"), similarly to the other call there.

Sounds reasonable?

Uli

I also meant to mention that there might be a reason why we want the out of memory error to bubble up to the caller should that happen while attempting to allocate the PyString in PyDict_GetItemString, rather than just bailing out with a generic FatalError.

Cheers,
T
_______________________________________________
Python-Dev mailing list
Python-Dev@python.org
http://mail.python.org/mailman/listinfo/python-dev
Unsubscribe: 
http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com

Reply via email to