On Mon, Apr 14, 2008 at 8:10 PM, Curt Hagenlocher <[EMAIL PROTECTED]> wrote:
> On Mon, Apr 14, 2008 at 9:12 AM, Ralf Schmitt <[EMAIL PROTECTED]> wrote: > > > > I've tracked it down to this change: > > http://hgpy.de/py/release25-maint/rev/e9446c6ab3cd > > this is svn revision 61009. > > [...] > > self._rbufsize if 1, and so the code reads one byte at a time > > The change is correct, but exposes a flaw earlier in the same method. > "_rbufsize == 1" represents a request to buffer "by line", which is > clearly irrelevant in this context. A request to read n bytes should > just use the default buffer size if buffering "by line". Sample patch > is attached. > Sorry to reply on the mailing list. But this change is wrong. e.g. if you're using a buffer size of 16 bytes and try to read 256 bytes, it should call recv with a value of 256 and not call recv 16 times with a value of 16. However, there should be an upper limit (as shown by the imap bug). Regards, - Ralf
_______________________________________________ Python-Dev mailing list Python-Dev@python.org http://mail.python.org/mailman/listinfo/python-dev Unsubscribe: http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
