On 7/25/06, Georg Brandl <[EMAIL PROTECTED]> wrote:
> Martin v. Löwis wrote:
> > Neal Norwitz wrote:
> >> # 74 Object/funcobject.c:143 Suspicious deref of ptr before NULL check
> >
> > Not quite sure what it is complaining about, but
> >
> > else if (PyTuple_Check(closure)) {
> > Py_XINCREF(closure);
> > }
> >
> > looks indeed suspicious: Why do we check for NULL (XINCREF) when
> > we know closure can't be NULL (Tuple_Check). Drop the X, and see
> > if the warning goes away
>
> In comparison, the PyFunction_SetDefaults function does check for
> NULL, and raises an error in this case. However, since it is a C API function
> only, passing NULL is an error anyway.
Heh, that was me that added it 10 days ago. :-)
Might as well do the same here.
n
_______________________________________________
Python-Dev mailing list
Python-Dev@python.org
http://mail.python.org/mailman/listinfo/python-dev
Unsubscribe:
http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
