On 7/6/2021 12:29 PM, Brian Curtin wrote:
Before looking at the code, my first question would be about the
description: "I kinda ran out of time, i suspect more testing is due."
If you were out of time then it's probably not done and maybe lacks the
tests you initially thought it did, so did you find the time
Tests were added later the same day. The opening comment should have
been edited (I made an attempt at it).
> and/or is the PR done?
Asked on PR.
--
Terry Jan Reedy
_______________________________________________
Python-Dev mailing list -- python-dev@python.org
To unsubscribe send an email to python-dev-le...@python.org
https://mail.python.org/mailman3/lists/python-dev.python.org/
Message archived at
https://mail.python.org/archives/list/python-dev@python.org/message/3UI6TTUZ5A5NPUHNBAEGSYWQSFWBGERK/
Code of Conduct: http://python.org/psf/codeofconduct/
