27.02.20 10:46, Chris Angelico пише:
On Thu, Feb 27, 2020 at 7:41 PM Serhiy Storchaka <storch...@gmail.com> wrote:
sympy/utilities/runtests.py

Sorry, but the current code

globs = globs.copy()
if extraglobs is not None:
      globs.update(extraglobs)

looks much clearer to me than the proposed

globs = globs | (extraglobs if extraglobs is not None else {})

Is there a reason for not writing it as:

globs = globs | (extraglobs or {})

? That reads fairly well to me.

Sure. Although it would work different if extraglobs is a false value different from None, empty mapping and iterable. But if we ignore such subtle details, it could be written also as

    globs = {**globs, **(extraglobs or {})}
_______________________________________________
Python-Dev mailing list -- python-dev@python.org
To unsubscribe send an email to python-dev-le...@python.org
https://mail.python.org/mailman3/lists/python-dev.python.org/
Message archived at 
https://mail.python.org/archives/list/python-dev@python.org/message/UYJ5VMSQPSS5WINGUWTTGI24IXJ6ABRC/
Code of Conduct: http://python.org/psf/codeofconduct/

Reply via email to