https://github.com/python/cpython/commit/40d07cad38bf3ce60f4ca03f1836e8650fe40df5
commit: 40d07cad38bf3ce60f4ca03f1836e8650fe40df5
branch: main
author: Ruiyang Ke <[email protected]>
committer: kumaraditya303 <[email protected]>
date: 2026-02-02T15:34:18+05:30
summary:
gh-144380: Fix incorrect type check in `buffered_iternext()` (#144381)
files:
A Misc/NEWS.d/next/Library/2026-02-01-15-25-00.gh-issue-144380.U7py_s.rst
M Modules/_io/bufferedio.c
diff --git
a/Misc/NEWS.d/next/Library/2026-02-01-15-25-00.gh-issue-144380.U7py_s.rst
b/Misc/NEWS.d/next/Library/2026-02-01-15-25-00.gh-issue-144380.U7py_s.rst
new file mode 100644
index 00000000000000..4b5b1b3776d735
--- /dev/null
+++ b/Misc/NEWS.d/next/Library/2026-02-01-15-25-00.gh-issue-144380.U7py_s.rst
@@ -0,0 +1 @@
+Improve performance of :class:`io.BufferedReader` line iteration by ~49%.
diff --git a/Modules/_io/bufferedio.c b/Modules/_io/bufferedio.c
index 6d779abd89ca84..0fdae7b2d21004 100644
--- a/Modules/_io/bufferedio.c
+++ b/Modules/_io/bufferedio.c
@@ -1505,8 +1505,8 @@ buffered_iternext(PyObject *op)
_PyIO_State *state = find_io_state_by_def(Py_TYPE(self));
tp = Py_TYPE(self);
- if (Py_IS_TYPE(tp, state->PyBufferedReader_Type) ||
- Py_IS_TYPE(tp, state->PyBufferedRandom_Type))
+ if (tp == state->PyBufferedReader_Type ||
+ tp == state->PyBufferedRandom_Type)
{
/* Skip method call overhead for speed */
line = _buffered_readline(self, -1);
_______________________________________________
Python-checkins mailing list -- [email protected]
To unsubscribe send an email to [email protected]
https://mail.python.org/mailman3//lists/python-checkins.python.org
Member address: [email protected]
