Eryk Sun <eryk...@gmail.com> added the comment:

PR 1927 is a definite improvement. By using _get_osfhandle() instead of caching 
the handle value, it guarantees that access to the original console file can be 
saved and restored via `fd_save = dup(fd)` and `dup2(fd_save, fd)`. It also 
allows duping a new open of CON, CONIN$, or CONOUT$, or even a new screen 
buffer from CreateConsoleScreenBuffer(), to the existing fileno(), and the 
_WindowsConsoleIO() instance will march along none the wiser.

----------
stage:  -> patch review
versions: +Python 3.10, Python 3.8, Python 3.9 -Python 3.6, Python 3.7

_______________________________________
Python tracker <rep...@bugs.python.org>
<https://bugs.python.org/issue30555>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to