Karthikeyan Singaravelan <tir.kar...@gmail.com> added the comment:
> This is already done in master branch ;) Thanks, I noticed the speed improvement in master and 3.7 but assumed it's due to some other optimisation in master. > Do you mind if I create PR for it? I would like to start contributing to > CPython ;) Sure, I will be happy to review. I would like to know others thoughts on this too on deferring whether the attribute is async check to the mock's own creation in _get_child_mock instead of making the parent mock construction slightly expensive as per the current approach. We can at least backport the NonCallableMock.__init__ signature fix which seems safe to make an improvement. Thanks ---------- _______________________________________ Python tracker <rep...@bugs.python.org> <https://bugs.python.org/issue38895> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
