Brad Miller <[EMAIL PROTECTED]> added the comment:
On Apr 17, 2008, at 4:26 PM, Amaury Forgeot d'Arc wrote:
>
> Amaury Forgeot d'Arc <[EMAIL PROTECTED]> added the comment:
>
> Some review of dv_range.patch:
>
> - repr(d.keys()) depends on the internal ordering of items, their hash
> values, the insertion order... the test seems fragile.
> Or you may rely on the fact that ints are their own hash values, so a
> small dict containing small keys will appear ordered. I suggest
> something like {6: 1.2, 1: 'A', 7: 42, 4: None}
I wondered about that, but my assumption was that the hash function
for strings and ints was equally unlikely to change. I can go with
all ints if that is really a safer assumption.
>
>
> - empty dicts or empty ranges will display:
> <range: >
> <dict_items: >
> Isn't there a better repr? At least this should appear in the tests.
I'm not sure how to represent that better.
<range: None>
<dict_items: None> -- These seem misleading
<range: empty>
<dict_items: empty> -- I'm not sure that is better than
<dict_items: > and empty may not mean anything to non-english speakers
I'll be happy to add the test for the empty case after once I know
what it should look like.
>
>
> ----------
> nosy: +amaury.forgeotdarc
>
> __________________________________
> Tracker <[EMAIL PROTECTED]>
> <http://bugs.python.org/issue2610>
> __________________________________
__________________________________
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue2610>
__________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe:
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
