On Fri, 2005-04-08 at 15:00 +0200, Filip Van Raemdonck wrote: > Hi, Please use Reply To All so that the list sees your reply too.
> On Thu, Mar 31, 2005 at 03:19:03PM +0200, Murray Cumming wrote: > > On Thu, 2005-03-31 at 13:47 +0100, Gustavo J. A. M. Carneiro wrote: > > > > > > If someone else will supply the patches and I just do > > > maintainer/review/minor-correction work, then definitely yes. I'm all > > > for it, and the "pygtk community" seems to think this a good idea. > > > > I guess that Filip and I can handle this, with some help sometimes. > > Shall I go ahead and add them to cvs? It might take me a couple of days > > to figure everything out. > > > > Filip, do you have a GNOME cvs account? > > No, I haven't. Do I need one? ;) Yes, I think you will. Here are some instructions: http://developer.gnome.org/doc/policies/accounts/requesting.html I am happy to apply patches for you until you get your account. > Anyway: I've dug out the changes I made since that first public release, > been trying to sync them to your checkin from a few days ago but I'm a bit > lost with what you changed in the checkin (or why you changed some > things). Mostly I changed stuff just to make it build and to make the examples work. I don't think that your pygda 0.3 tarball built for me either. I'm not an expert on any of this stuff. > In random order: > > In gdamodule.c there is this: > ----cut--- > 12 : /* This was in pygda 0.3, but is not in other *module.c files > in gnome-python-extras. murrayc. > 13 : bindtextdomain (GETTEXT_PACKAGE, GDA_LOCALEDIR); > 14 : bind_textdomain_codeset (GETTEXT_PACKAGE, "UTF-8"); > 15 : */ > ----cut--- > > I can see why you removed these, but I'm not sure if they should've been. I have no idea. I didn't see them in other parts of gnome-python-extras or gnome-python, but I didn't look everywhere. > I put these in because they came from gda_init() which is never called in > the python module. Note that I did had set GETTEXT_PACKAGE to libgda-2, > too. The idea obviously was that libgda warnings or errors be localized. > > Another thing, in gda.defs all functions have the gda_ prefix. I > specifically left these out as a change in my (prerelease) 0.0.2 bindings, > and I believe other bindings do it the same way. Am I mistaken, has > something changed since I did those bindings, have I simply missed > something? Is there a reason these prefixes are back or is it simply > because you regenerated the .defs file from scratch? (Don't know if you > actually did, I'm just guessing) Yes, I regenerated the defs file, and added your BoxedTypes definitions to it. I don't know what's normal, but I guessed that h2defs.py would create correct .defs, and it seems to work. With your .defs, I got a lot of error messages during generation. Are you using the latest pygtk? > Next, everything from gda-error.h appears to be missing from the .defs > file. Is this on purpose or by accident? No, let's add that back then. > I do have a patch (attached) which was the most important change, against > your checkin. It adds a config_get_key function, and does removes the > config_get_<type> functions. It doesn't make lot of sense to have various > config_get_<type> methods in a dynamically type language IMHO :) > I do not know if it works with the CVS code; it did work in my codebase > and I don't see why it shouldn't know. Yes, that looks good. Is it normal to change the .defs (which should describe the C API) to get a different python API? -- Murray Cumming [EMAIL PROTECTED] www.murrayc.com www.openismus.com _______________________________________________ pygtk mailing list [email protected] http://www.daa.com.au/mailman/listinfo/pygtk Read the PyGTK FAQ: http://www.async.com.br/faq/pygtk/
