Hi Jon, As you have read, this is part of our work implementing errors to enforce the standards set down in PUP-1434. In particular, your example '$module_path/seed/manifests/init.pp' looks like it is in the init file of module 'seed'. Assuming that is what you meant, anything starting with 'seed' would be OK in that file, e.g. 'seed', 'seed::remote_file', 'seed::foo::remote_file' would all work. Note that as part of point 4. of PUP-1434 (now being implemented in the work of PUP-9020), you will also not be allowed to put things like resources in the top level, but instead should include your resources in a class, define, function, or type declaration.
Kris Bosland Senior Software Engineer, Puppet inc. On Tuesday, August 28, 2018 at 9:12:27 AM UTC-7, [email protected] wrote: > > Guess I should have read to point 6 in PUP-1434, init.pp is special. Got > it, thanks a bunch. > > Jon > > On Tuesday, 28 August 2018 10:08:16 UTC-6, [email protected] wrote: >> >> So does this mean if the path is '$module_path/seed/manifests/init.pp' then >> the define name will now need to be 'seed::init::remote_file' in place of >> 'remote_file'? >> >> Thanks, >> Jon >> >> On Tuesday, 28 August 2018 09:50:48 UTC-6, Branan Purvine-Riley wrote: >>> >>> Hi Jon, >>> >>> In Puppet 6 we're going to start requiring that the names of >>> classes/defines match the name that's implied by their file path[1]. We >>> added that deprecation warning in 5.5.6[2] as part of a push to get >>> upcoming Puppet 6 changes printing warnings whenever possible. >>> >>> [1] https://tickets.puppetlabs.com/browse/PUP-1434 and >>> https://tickets.puppetlabs.com/browse/PUP-4242 >>> [2] https://tickets.puppetlabs.com/browse/PUP-8894 >>> >>> >>> On Tue, Aug 28, 2018 at 8:31 AM <[email protected]> wrote: >>> >>>> I was away on vacation for a month, upon getting back I am finding the >>>> Puppet Agent is now throwing a warning on all of the defines I have in a >>>> module that is applied to all our Linux servers. (we are auto updating >>>> point releases) >>>> >>>> Warning: Unacceptable location. The name 'remote_file' is unacceptable >>>> in file '/etc/puppet/modules/seed/manifests/init.pp' (file: >>>> /etc/puppet/modules/seed/manifests/init.pp, line: 1123, column: 1) >>>> >>>> We have several defines in this module, all now causing the same >>>> warning message and wasn't a few months ago. I couldn't find anything in >>>> the 5.5.x release notes to explain why this warning has started to pop up. >>>> >>>> In this case the define warned about above looks like: >>>> >>>> define remote_file($remote_location=undef, $mode='0644', $owner=undef, >>>> $group=undef) { >>>> Code here >>>> } >>>> >>>> Thanks in advance for any ideas anyone might have on why this warning >>>> has started to pop up. >>>> >>>> Jon >>>> >>>> -- >>>> You received this message because you are subscribed to the Google >>>> Groups "Puppet Users" group. >>>> To unsubscribe from this group and stop receiving emails from it, send >>>> an email to [email protected]. >>>> To view this discussion on the web visit >>>> https://groups.google.com/d/msgid/puppet-users/673af078-aadf-4c43-8f8a-c451f688a85f%40googlegroups.com >>>> >>>> <https://groups.google.com/d/msgid/puppet-users/673af078-aadf-4c43-8f8a-c451f688a85f%40googlegroups.com?utm_medium=email&utm_source=footer> >>>> . >>>> For more options, visit https://groups.google.com/d/optout. >>>> >>> -- >>> Regards, >>> >>> Branan Riley >>> Senior Software Engineer, Puppet inc. >>> >> -- You received this message because you are subscribed to the Google Groups "Puppet Users" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-users/93481032-0202-4576-9974-ef81887ece0a%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
