Pull request triage - 2014-05-14
Joined: Adrien, Andy, BrianL, Charlie, Erik Dalén (community), Ethan, Felix
(community), Henrik, JoshC, JoshuaP, PeterH, Zach
Candidates for merging:
- 2492: (PUP-1381) issue warnings to current users of cron purging
- 2473: (PUP-1775) Acquire and block for Yum's lock to prevent corruption
- 2479: (PUP-2031) unless_uid on user is completely broken wrt ranges
- 2549: (PUP-2298) add support for Type#in_valid_catalog? methods to
transaction
- 2575: (PUP-2360) Yumrepo type allows invalid values
- 2577: (PUP-2356) Added some extra yumrepo options
- 2557: (TBD) Unbreak OpenBSD services from packages which set local flags
- 2558: (TBD) upgradeable OpenBSD package provider
- 2563: (PUP-2311) OpenBSD uninstall broken with multiple
uninstall_options
- 2547: (PUP-2454) Don't purge system users on OpenBSD
- 2606: (doc) Document ssh_authorized_key purging
- 2615: (PUP-2458) Tests for providers inheriting from providers of
another type
- 559: (FACT-233) Add dhcp_server fact
merged, but requires follow-up given there may need to be a new
ticket for F20
Held over:
Puppet:
2492: (PUP-1381) issue warnings to current users of cron purging
- Sending back to felix with the suggestion that he try option 3.
- Felix to keep tinkering on it, Andy to look more closely.
- Ready for review, Andy to pull into sprint for 3.7.x
2473: (PUP-1775) Acquire and block for Yum's lock to prevent corruption
- domcleal verified it works, Adrien to pull into this week's sprint
- Adrien commented that using 'yum update-check' might be better
- Discussion is still ongoing
- It looks like yumhelper could get completely deleted per Adrien /
Charlie
- Adrien to take on fixing up the timeout issue, rebasing and merging
2472: (PUP-2040) Allow excluding files from module build package
- ping Alex or Ryan and ask where they want to take this. (2x)
- Still no clear direction from Ryan and Co about where this should go (I
think we should close it)
- Still no clear direction, Henrik to comment
2468 (PUP-2079): Add mechanism to allow template files to be copied without
getting parsed
- This is a modules/forge team, Adrien to ping everybody remotely related
to the forge
- The changes that were blocking this have landed. Kylo pinging pvande
again.
- Need to ping pvande again to verify / merge
- Still no response, will wait another week
2479: (PUP-2031) unless_uid on user is completely broken wrt ranges
- This removes pseudo ranges from unless_uid, adds comma separated values
- Further simplify inputs to [String | Integer | Array<String | Integer>]
- PeterH to take
- PeterH didn't get to it. PeterH to take now
- Decided to take current PR as is. This change will backout special
Range syntax, and users should use range function in stdlib
2549: (PUP-2298) add support for Type#in_valid_catalog? methods to
transaction
- What sort of hooks do we want to define over the application lifetime?
- Implement validate method on Type ancestor class, change method name
something like `#check_constraints`
- Latest set of changes looks good, but the pre_run_check should happen
on the catalog evaluation
- Adrien to ping Felix based on TravisCI failures
- Thumbs up, Adrien to pull into next sprint or two
2501: (maint) Return last serial from SSL inventory
- Adrien pinged Erik Dalén, if he doesn't respond by 5/14, we should pull
in to sprint and merge
- Erik updated the PR
- Andy to log a ticket, continue discussion on ticket, e.g. revoke all
certificates for a specified name
2575: (PUP-2360) Yumrepo type allows invalid values
- Adrien to ping contributor about additional tests
- Basically looks good to merge once tests are in place
- PR spec tests updated
2577: (PUP-2356) Added some extra yumrepo options
- Charlie to follow up with contributor on test failures
- Otherwise, Adrien and Charlie give this the +1
- PR spec tests updated for ruby 1.8.7, Adrien to add to next sprint or
two
Facter:
New:
Puppet:
2639: (PUP-1843) Restore hiera indirector terminus
- Erik to update PR to avoid code duplication
2557: (TBD) Unbreak OpenBSD services from packages which set local flags
- Needs ticket and tests
- Adrien to pull into sprint or next
2558: (PUP-1069) upgradeable OpenBSD package provider
- Second PR to adding this functionality
- Adrien to comment in the PR that we want this but will need to defer
another week
2563: (PUP-2311) OpenBSD uninstall broken with multiple uninstall_options
- Adrien to merge
2547: (PUP-2454) Don't purge system users on OpenBSD
- Current behavior is dangerous on OpenBSD & Debian, this would provide
incremental improvement
- Will pull into sprint after next
2606: (doc) Document ssh_authorized_key purging
- JoshuaP to merge and update DOC-745 ticket
2605: (PUP-1381) Read all crontabs
- Felix to update PR with JIRA ticket for 4.0
- Felix to file separate deprecation_warning ticket for 3.7
2615: (PUP-2458) Tests for providers inheriting from providers of another
type
- Andy to merge to 3.7.0
2616: (PUP-1070) Cleanup empty/invalid lockfile
- Puppet used to use an empty lockfile to mean the agent is
administratively disabled
- Andy and Adrien to add comments
Erik brought up a bug with Puppet::Agent::Locker#lock implementation not
matching its documentation. There's no way for the caller to know if the
lock was acquired. JoshC filed PUP-2573. We also talked about race
conditions in Puppet::Agent#run, and JoshC filed as PUP-2574
Josh
--
You received this message because you are subscribed to the Google Groups
"Puppet Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/puppet-dev/663affc9-c826-429d-9d55-b63b93c46ff8%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
