Jira (PUP-3861) Pull request #2670 will break yum provider with long package names

[Adrien Thebo (JIRA)]

Title: Message Title

Adrien Thebo commented on PUP-3861   Re: Pull request #2670 will break yum provider with long package names https://github.com/puppetlabs/puppet/pull/2670#issuecomment-62093402 discussed using repoquery over directly invoking yum, but it was decided against as we would have to add yum-utils as a hard dependency. As it turns out, I actually had fixed this but I didn't push my patch and so it didn't get merged. Good times. This is part of the patch that will fix this; I'll add more information later. /cc Charlie Sharpsteen feel free to bug me on this more if I don't respond in a timely manner. Anywho, patch: diff --cc lib/puppet/provider/package/yum.rb index 0c0ac2a,4a9f06b..0000000 --- i/lib/puppet/provider/package/yum.rb +++ w/lib/puppet/provider/package/yum.rb @@@ -63,28 -62,26 +63,49 @@@ Puppet::Type.type(:package).provide :yu # @api private # @param enablerepo [Array<String>] A list of repositories to enable for this query # @param disablerepo [Array<String>] A list of repositories to disable for this query + # @param disableexcludes [Array<String>] A list of repository excludes to disable for this query # @return [Hash<String, Array<Hash<String, String>>>] All packages that were # found with a list of found versions for each package. ++<<<<<<< HEAD + def self.check_updates(enablerepo, disablerepo, disableexcludes) + args = [command(:yum), 'check-update'] + args.concat(enablerepo.map { |repo| ["--enablerepo=#{repo}"] }.flatten) + args.concat(disablerepo.map { |repo| ["--disablerepo=#{repo}"] }.flatten) + args.concat(disableexcludes.map { |repo| ["--disableexcludes=#{repo}"] }.flatten) + + output = Puppet::Util::Execution.execute(args, :failonfail => false, :combine => false) + + updates = {} + if output.exitstatus == 100 + updates = parse_updates(output) + elsif output.exitstatus == 0 + self.debug "yum check-update exited with 0; no package updates available." + else + self.warn "Could not check for updates, 'yum check-update' exited with #{output.exitstatus}" + end + updates + end + ++======= + def self.check_updates(enablerepo, disablerepo) + args = [command(:yum), 'check-update'] + args.concat(enablerepo.map { |repo| ['-e', repo] }.flatten) + args.concat(disablerepo.map { |repo| ['-d', repo] }.flatten) + + output = Puppet::Util::Execution.execute(args, :failonfail => false, :combine => false) + + updates = {} + if output.exitstatus == 100 + updates = parse_updates(output) + elsif output.exitstatus == 0 + self.debug "yum check-update exited with 0; no package updates available." + else + self.warn "Could not check for updates, 'yum check-update' exited with #{output.exitstatus}" + end + updates + end + ++>>>>>>> 2d9624e... (PUP-1362) Use yum check-updates for latest yum packages Add Comment   This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.