Jira (PUP-2885) Periodic timeouts when reading from master

Josh Cooper (JIRA) Wed, 02 Jul 2014 17:18:07 -0700

Title: Message Title

Josh Cooper commented on an issue

I think the agent is doing two things wrong when it comes to network communications.

First, it sets socket connect and read timeout to Puppet[:configtimeout], which defaults to 2 minutes:

                                                          @connection.read_timeout = Puppet[:configtimeout]
      @connection.open_timeout = Puppet[:configtimeout]

The connect timeout (open_timeout) is okay, though I would prefer that we expose these socket timeouts as separate settings.

The read timeout should really be 0 (indefinite). This way the agent will block indefinitely while waiting for the master's response, and if the master closes the connection, then the client will receive a TCP RST and be interrupted.

The second issue is the pluginsync is performed in a timeout block with a default 2 minute timeout. This doesn't make any sense. The timeout will be triggered if the agent takes more than 2 minutes to complete the entire pluginsync operation, even if it is making progress downloading individual files:

                                                          ::Timeout.timeout(Puppet[:configtimeout]) do
        catalog.apply do |trans|
          trans.changed?.find_all do |resource|
            yield resource if block_given?
            files << resource[:path]
          end
        end
      end

                                                

I think we should remove the Timeout block and change the read socket timeout to 0.

Add Comment

Puppet /

PUP-2885

Periodically, there are failures where the agent performs a pluginsync, a number of files are downloaded from the master, and eventually one of the files hangs, timeouts, and causes the pluginsync to abort.

This message was sent by Atlassian JIRA

--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.

Jira (PUP-2885) Periodic timeouts when reading from master

Reply via email to