Jira (PDB-527) PR (897): Terminus: support an alternate HTTP client for JRuby - cprice404

[gepetto-bot (JIRA)]

Title: Message Title

gepetto-bot commented on an issue   Re: PR (897): Terminus: support an alternate HTTP client for JRuby - cprice404 kbarber commented: > @kbarber I can't do anything in P::N::HttpClient without monkey patching, and I'd really prefer to avoid that. Why? > This code is for a very specific use case that has to do with termini that need to make HTTPS requests; I believe that this pattern will need to be used in other termini, such as the classifier, as well. The code isn't general to Puppet, but it's also not specific to one particular terminus, so this approach is the best I've come up with so far. So why wouldn't a monkey patch be better in this case, if its going to be used by multiple plugins? If the behaviour is compatible this makes more sense instead of patching all plugins to use an alternate implementation. My main point is not around the specific implementation, its around expecting each other plugin to be aware of this magic we have created. Its just not a clearly defined API to me, and it feels like its not well thought out beyond fixing this particular problem - perhaps you can explain the next steps of evolution for such a contract. Add Comment   PuppetDB / PDB-527 PR (897): Terminus: support an alternate HTTP client for JRuby - cprice404 h2. Terminus: support an alternate HTTP client for JRuby  * Author: Chris Price <>  * Company:  * Github ID: [cprice404|https://github.com/cprice404]  * [Pull Request 897 Discussion|https://github.com/puppetlabs/puppetdb/pull/897]  * [Pull Request 897 File Diff|https://github.com/puppetlabs/puppetdb/pull/897/files] h2. Pull Request Description ---- Th... This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.