Jira (FACT-3196) Facter on Solaris 10 seems to leak file descriptors, causing puppet run failures

[Josh Cooper (Jira)]

Title: Message Title

Josh Cooper commented on FACT-3196   Re: Facter on Solaris 10 seems to leak file descriptors, causing puppet run failures I ran reproduce locally: $ bundle exec rake ci:test:setup SHA=7.24.0 HOSTS=solaris10-64a $ ssh ... -bash-3.2# ulimit -n 256 -bash-3.2# /opt/puppetlabs/puppet/bin/facter networking > /dev/null -bash-3.2# ulimit -n 200 -bash-3.2# /opt/puppetlabs/puppet/bin/facter networking > /dev/null [2023-04-10 10:50:40.385688 ] ERROR Facter::Resolvers::Solaris::Networking - can't modify frozen String: "" The problem is that facter does not close these socket descriptors: -bash-3.2# truss -o truss.out -t open,openat,close,so_socket,pipe /opt/puppetlabs/puppet/bin/facter networking -bash-3.2# export TERM=vt100 -bash-3.2# more truss.out ... /1: so_socket(PF_INET, SOCK_DGRAM, IPPROTO_IP, "", SOV_DEFAULT) = 12 /1: so_socket(PF_INET, SOCK_DGRAM, IPPROTO_IP, "", SOV_DEFAULT) = 13 /1: so_socket(PF_INET, SOCK_DGRAM, IPPROTO_IP, "", SOV_DEFAULT) = 14 /1: pipe() = 15 [16] /1: pipe() = 17 [18] /1: pipe() = 19 [20] /1: pipe() = 21 [22] /1: close(22) = 0 /1: close(21) = 0 /1: close(15) = 0 /1: close(18) = 0 /1: close(20) = 0 /1: close(16) = 0 /1: close(17) = 0 /1: close(19) = 0 Note descriptors 12, 13, 14 are never closed. The problem occurs here https://github.com/puppetlabs/facter/blob/21917020bc48c612b490911e904f5dbddf7e6c3b/lib/facter/resolvers/solaris/ffi/functions.rb#L17-L19. If ioctl_base raises, then the descriptor is not closed. Add Comment   This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.483921.1680664430000.3998.1681149480025%40Atlassian.JIRA.