Jira (PUP-11435) Puppet 6.26 and 7.13 may cause specs to fail

[Josh Cooper (Jira)]

Title: Message Title

Josh Cooper updated an issue   Puppet / PUP-11435 Puppet 6.26 and 7.13 may cause specs to fail Change By: Josh Cooper Commit 78246ca8d08dee770886f0940a6472c45483d627 first released in 6.26.0 and 7.13.0 speeds up rspec tests but breaks puppet-enteprise-modules due to the way {{Facter.reset}} breaks stubbing for a custom fact. [https://github.com/puppetlabs/puppet/commit/78246ca8d08dee770886f0940a6472c45483d627] This ticket is to: 1. Delete the call to {{Facter.reset}} line in [https://github.com/puppetlabs/puppet/blob/4772afa194402a3876069785a178611797a8eb7d/lib/puppet/defaults.rb#L1998] 2. Optional (attempt 1), try adding {{Facter.reset}} to puppet's [spec_helper.rb|https://github.com/puppetlabs/puppet/blob/4772afa194402a3876069785a178611797a8eb7d/sec/spec_helper.rb]. That way the facter search path is reset across tests, but it's only triggered when running puppet's spec tests. But not when a module runs tests and calls puppet as a library. 3. Optional (attempt 2), if attempt 1 doesn't work, try adding {{Facter.reset}} to puppet's [test helper|https://github.com/puppetlabs/puppet/blob/4772afa194402a3876069785a178611797a8eb7d/lib/puppet/test/test_helper.rb#L145-L146] This likely has to be done after the call to {{ {} Puppet.runtime[:facter] { }} } . Note this code will be invoked by modules that are using puppetlabs_spec_helper. 4. If neither work, just omit the call to Facter.reset entirely. 5. A more complete fix is to understand why this issue affects PE modules, but not a custom module generated via pdk (see comment below). To reproduce the issue: {code:shell}$ git clone g...@github.com:puppetlabs/puppet_enterprise_modules $ cd puppet_enterprise_modules $ git revert f8ec0e5d9234be99b3566034e921d797fb85ea43 $ PUPPET_VERSION="6.26.0" bundle install --without system_tests  $ cd modules/puppet_enterprise $ PUPPET_VERSION="6.26.0" bundle exec rake spec SPEC=spec/unit/facter/inventory_spec.rb ... Failures:  1) inventory facts the inventory and metadata facts when setting the inventory fact wil be populated when enabled      Failure/Error: expect(Facter.value('_puppet_inventory_1')).not_to be nil              expected not #<NilClass:8> => nil                 got #<NilClass:8> => nil              Compared using equal?, which compares object identity.      # ./spec/unit/facter/inventory_spec.rb:77:in `block (4 levels) in <top (required)>'  2) inventory facts the inventory and metadata facts when setting the metadata fact sets enabled to true if enabled      Failure/Error: expect(Facter.value('puppet_inventory_metadata')['packages']['collection_enabled']).to be true              expected true             got false      # ./spec/unit/facter/inventory_spec.rb:89:in `block (4 levels) in <top (required)>'Finished in 0.16165 seconds (files took 0.97491 seconds to load) 9 examples, 2 failures Failed examples: rspec ./spec/unit/facter/inventory_spec.rb:75 # inventory facts the inventory and metadata facts when setting the inventory fact wil be populated when enabled rspec ./spec/unit/facter/inventory_spec.rb:87 # inventory facts the inventory and metadata facts when setting the metadata fact sets enabled to true if enabled{code} But if then downgrade to 6.25.1 it works: {code} $ PUPPET_VERSION="6.25.1" bundle update ... Using puppet 6.25.1 (was 6.26.0) ... $ PUPPET_VERSION="6.25.1" bundle exec rake spec SPEC=spec/unit/facter/inventory_spec.rb ... Finished in 0.08799 seconds (files took 0.97687 seconds to load) 9 examples, 0 failures {code} Add Comment   This message was sent by Atlassian Jira (v8.20.2#820002-sha1:829506d) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.432469.1643158630000.13069.1644449100043%40Atlassian.JIRA.