Jira (PUP-10925) Default timeout not respected for Windows services

[Gabriel Nagy (Jira)]

Title: Message Title

Gabriel Nagy created an issue   Puppet / PUP-10925 Default timeout not respected for Windows services Issue Type: Bug Assignee: Unassigned Created: 2021/02/18 8:01 AM Priority: Normal Reporter: Gabriel Nagy Puppet Version: 6.21.1 Puppet Server Version: n/a OS Name/Version: Windows Windows services have a timeout for service-related operations that defaults to 30 seconds, as seen here: https://github.com/puppetlabs/puppet/blob/e4a654400a4c1ad3b5bc73fb558d28219a4626b2/lib/puppet/util/windows/service.rb#L24 This variable is used in the following method: https://github.com/puppetlabs/puppet/blob/c6412ea369aa1613ca166b10fb819fcf6130814b/lib/puppet/provider/service/windows.rb#L118 The method is called in the base service type: https://github.com/puppetlabs/puppet/blob/e4a654400a4c1ad3b5bc73fb558d28219a4626b2/lib/puppet/type/service.rb#L301 Desired Behavior: Not setting the timeout parameter on a Windows service should cause it to default to 30 seconds. Actual Behavior: Not setting the timeout parameter on a Windows services causes it to default to 10 seconds.   The line in the service type should change from: defaultto { provider.class.respond_to?(:default_timeout) ? provider.default_timeout : 10 } to defaultto { provider.respond_to?(:default_timeout) ? provider.default_timeout : 10 } Add Comment   This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.387947.1613664109000.145103.1613664120107%40Atlassian.JIRA.