Jira (HI-578) Symbolized facts causes "ignore bad definition" error in hierarchy

[Henrik Lindberg (JIRA)]

Title: Message Title

Henrik Lindberg commented on HI-578   Re: Symbolized facts causes "ignore bad definition" error in hierarchy Dan Dunckel What I want to know is how facts ended up being encoded with symbols as keys - they are not supposed to be in that form. I therefore think that the problem is in how tests are set up. That is - something brought in by these: require "puppetlabs_spec_helper/module_spec_helper" require "rspec-puppet-facts" include RspecPuppetFacts We do not want $facts to be populated with symbol keys. While that may have worked in the past because there was string/symbol monkey patching in place that equated symbols with strings - that monkeypatch is gone in puppet 5 because of all the problems it created. We do not want that back and the correct thing to do here is to ensure that tests feed the right data into the rest of the machinery. The proposed solution, to search again with the key turned into a symbol has several other problems: it makes all searches slower since for every key that is not found in a particular backend, there would be an extra lookup. hiera 3 is deprecated in favor of hiera 5, and the change does not carry forward I think the real solution is to fix the testing framework. Add Comment   This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.