Jira (PUP-7447) Need prescriptive method for combining 'lookup' with ENCs and the Roles/Profiles pattern (aka, lookup should look up the entire stack)

Thomas Hallgren (JIRA) Tue, 18 Apr 2017 05:59:43 -0700

Title: Message Title

Thomas Hallgren commented on

PUP-7447

I don't understand this hierachy:

Hiera -> Class Declarations (Profiles) -> normal lookup() stuff

Hiera IS the normal lookup stuff. They are not two separate things. Perhaps you mean:

Global layer -> Class Declarations (Profiles) -> Environment layer -> Module layer ?

If so, then it should be easy enough to achieve by just adding a lookup_key function, either at the end of the global hierarchy or at the start of the environment hierarchy, that essentially performs the same task as the simplib::lookup but calls context#not_found unless it finds the global value. By doing that, you gain the following advantages:

You get the desired hierarchy.
You get explain support.
Values can be merged.

Instead of calling closure_scope, I'd recommend injecting it into a parameter. Like this:

Puppet::Functions.create_function(:'my::scope_lookup', Puppet::Functions::InternalFunction) do

  dispatch :scope_lookup do

    scope_param

    param 'String[1]', :key

    param 'Hash[String[1],Any]', :options

    param 'Puppet::LookupContext', :context

end

  def scope_lookup(scope, key, options, context) {

    # find and return key here

    context.not_found   # called if the key is not found. There is no return from this method

Adding this function in a Hierarchy is simple. Just do:

hierarchy:

   - name: Global Scope

     lookup_key: my::scope_lookup

Add Comment

This message was sent by Atlassian JIRA

--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.

Jira (PUP-7447) Need prescriptive method for combining 'lookup' with ENCs and the Roles/Profiles pattern (aka, lookup should look up the entire stack)

Reply via email to