Jira (PUP-6669) Puppet should return better errors for Enum mismatches

[JIRA]

Title: Message Title

Igor Galić created an issue   Puppet / PUP-6669 Puppet should return better errors for Enum mismatches Issue Type: Bug Assignee: Unassigned Created: 2016/09/01 5:47 AM Priority: Normal Reporter: Igor Galić given the following code: define foo ( Optional[Enum['foo', 'bar']] $x ){ notify { $x: } } foo { 'lolnope': x => 'baz', } Puppet will return this Error: Error: Evaluation Error: Error while evaluating a Resource Statement, Foo[lolnope]: parameter 'x' expects a match for Enum['bar', 'baz'], got String at /tmp/foo.pp:6 on node levix my naïve patch: diff --git a/lib/puppet/pops/types/type_mismatch_describer.rb b/lib/puppet/pops/types/type_mismatch_describer.rb index 98763ad..3f11e96 100644 --- a/lib/puppet/pops/types/type_mismatch_describer.rb +++ b/lib/puppet/pops/types/type_mismatch_describer.rb @@ -578,7 +578,7 @@ module Types value = param_hash[name] value_type = elem.value_type if param_hash.include?(name) - result << describe(value_type, TypeCalculator.singleton.infer_set(value).generalize, [ParameterPathElement.new(name)]) unless value_type.instance?(value) + result << describe(value_type, TypeCalculator.singleton.infer_set(value), [ParameterPathElement.new(name)]) unless value_type.instance?(value) else result << MissingParameter.new(nil, name) unless elem.key_type.assignable?(PUndefType::DEFAULT) unless missing_ok end works for this case, but breaks other types — in particular the new Sensitive type. Add Comment   This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.