Hi Colin, On 20/12/2008, Colin Guthrie <[email protected]> wrote: > Hi Tom, > > Thanks for your contributions. I'm not an expert in RTP stuff so I can't > really review, but here is some general advice about contributions. > > The normal procedure is to make a git clone of the official code > repository (the details are on the website) and then make your changes > there. > > The process would be something like: > git clone git://git.0pointer.de/pulseaudio > cd pulseaudio > git checkout -b mybranch > <do work & change files> > > > You can then review your own changes via "git diff" to make sure you're > not making any changes you didn't mean to! > > Once you are happy with your changes changes you "commit" them into your > checkout by running: > git commit -am "Description of my changes" > > (the -a bit just says to commit all modified files, if you only want to > commit a subset, run "git add <filename>" and miss out the -a flag on > your commit) > > Once you are happy you would publish your changes upstream. There are a > few ways to do this with the built in git tools, but a simple way to get > you started is to create a series of patches via: > git format-patch master..mybranch > > This will create a series of files all ending in .patch. These files > represent the differences between the master branch and your local branch. > > You should then either post these files here on the mailing list or > create a ticket in Trac and attach them there. > > The Trac route is less likely to be overlooked, but Lennart may prefer > the patches here for review. > > I hope this helps. > > Col > > > > -- > > Colin Guthrie > gmane(at)colin.guthr.ie > http://colin.guthr.ie/ > > Day Job: > Tribalogic Limited [http://www.tribalogic.net/] > Open Source: > Mandriva Linux Contributor [http://www.mandriva.com/] > PulseAudio Hacker [http://www.pulseaudio.org/] > Trac Hacker [http://trac.edgewall.org/] > > _______________________________________________ > pulseaudio-discuss mailing list > [email protected] > https://tango.0pointer.de/mailman/listinfo/pulseaudio-discuss >
Thank you for your advice. I've followed this procedure and attached a patch to this message. I apologise if I hit the mailing list twice with this message, gmail is so unreliable on slow connections. The extra lines just apply the same TTL to outgoing SDP packets as the RTP packets in the module-rtp-send mod. Kind Regards, Tom Bamford
From 1ac5d23ffb6df36c8ca34fe312513f743d396c72 Mon Sep 17 00:00:00 2001 From: Tom Bamford <[email protected]> Date: Sat, 20 Dec 2008 23:44:09 +0200 Subject: [PATCH] Multicast SDP packets sent with same IP TTL as RTP packets --- src/modules/rtp/module-rtp-send.c | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/src/modules/rtp/module-rtp-send.c b/src/modules/rtp/module-rtp-send.c index 8d1e92f..c5842f9 100644 --- a/src/modules/rtp/module-rtp-send.c +++ b/src/modules/rtp/module-rtp-send.c @@ -296,6 +296,11 @@ int pa__init(pa_module*m) { pa_log("IP_MULTICAST_TTL failed: %s", pa_cstrerror(errno)); goto fail; } + + if (setsockopt(sap_fd, IPPROTO_IP, IP_MULTICAST_TTL, &_ttl, sizeof(_ttl)) < 0) { + pa_log("IP_MULTICAST_TTL (sap) failed: %s", pa_cstrerror(errno)); + goto fail; + } } /* If the socket queue is full, let's drop packets */ -- 1.5.6.3
_______________________________________________ pulseaudio-discuss mailing list [email protected] https://tango.0pointer.de/mailman/listinfo/pulseaudio-discuss
