On Tue, 10 May 2016, at 11:40 AM, Sachin Kumar Chauhan wrote: > BugLink: https://bugs.freedesktop.org/show_bug.cgi?id=95293 > > Signed-off-by: Sachin Kumar Chauhan <[email protected]> > ---
Thanks, I've merged this now with some changes. You might want to look at those for future patches. Summarising: 1. The commit message should follow the pattern of a short summary (72 chars is the convention), followed by a longer description 2. pa_xfree() accepts and ignores NULLs, so removed the check around the call (this one's down to style, so either is okay, really) 3. In general, we use if (...) not if(...) -- again, this is trivial, but do try to maintain consistency Cheers, Arun _______________________________________________ pulseaudio-discuss mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss
