Ack, looks good.

On 2016-02-12 01:08, Ahmed S. Darwish wrote:
The daemon `shm-size-bytes' configuration value was read, and then
directly used, for creating the initial server-wide SHM files.

This is fine for now, but soon, such server-wide SHMs will be replaced
with per-client SHM files that will be dynamically created and deleted
according to clients open and close. Thus, appropriately cache this
configuration value.

Signed-off-by: Ahmed S. Darwish <[email protected]>
---
  src/pulsecore/core.c | 1 +
  src/pulsecore/core.h | 5 +++++
  2 files changed, 6 insertions(+)

diff --git a/src/pulsecore/core.c b/src/pulsecore/core.c
index 43fd30e..b2df7de 100644
--- a/src/pulsecore/core.c
+++ b/src/pulsecore/core.c
@@ -123,6 +123,7 @@ pa_core* pa_core_new(pa_mainloop_api *m, bool shared, 
size_t shm_size) {
      c->subscription_event_last = NULL;

      c->mempool = pool;
+    c->shm_size = shm_size;
      pa_silence_cache_init(&c->silence_cache);

      if (shared && !(c->rw_mempool = pa_mempool_new(shared, shm_size)))
diff --git a/src/pulsecore/core.h b/src/pulsecore/core.h
index aefc1eb..428689c 100644
--- a/src/pulsecore/core.h
+++ b/src/pulsecore/core.h
@@ -181,6 +181,11 @@ struct pa_core {
         The rw_mempool is used for data writable by both server and client (and
         can be NULL in some cases). */
      pa_mempool *mempool, *rw_mempool;
+
+    /* Shared memory size, as specified either by daemon configuration
+     * or PA daemon defaults (~ 64 MiB). */
+    size_t shm_size;
+
      pa_silence_cache silence_cache;

      pa_time_event *exit_event;


Regards,


--
David Henningsson, Canonical Ltd.
https://launchpad.net/~diwic
_______________________________________________
pulseaudio-discuss mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss

Reply via email to