'Twas brillig, and Peter Meerwald at 12/12/11 12:44 did gyre and gimble: > From: Peter Meerwald <[email protected]> > > ATTENTION: pa_proplist_unset() and pa_proplist_contains() have unconventional > return codes (-2/-1/0) and -1/0/1, resp.); this aims to document the current > behaviour, however, it might as well be a bug...
As mentioned in previous replies, this ins't unconventional. 0 and 1 are successful return values whereas all errors result in a negative return value. Therefore I'm not sure it's worth being totally explicit here with the exact return values and the error conditions. Some of the comment changes in this patch are valid even considering my reservations on the above so feel free to resubmit this with just these changes. If we decide (as a result of the other thread) to fully document all error return values then we can revisit this patch in it's entirety. Cheers Col -- Colin Guthrie gmane(at)colin.guthr.ie http://colin.guthr.ie/ Day Job: Tribalogic Limited http://www.tribalogic.net/ Open Source: Mageia Contributor http://www.mageia.org/ PulseAudio Hacker http://www.pulseaudio.org/ Trac Hacker http://trac.edgewall.org/ _______________________________________________ pulseaudio-discuss mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss
