On 21 Oct 01:33, Mateusz Gozdek wrote: > Hi all, > > While recently contributing for the first time to Prometheus code base, > I've noticed that the Go source files could be more consistently formatted. > My IDE is configured for a long time to use "gofumpt" and "gci" formatters > on file save, so "git diff" was producing a lot of unrelated changes to me, > which is a bit annoying if one wants to produce clean commits without mixed > changes, so some "git add -p" dance was required almost all the time. > > Considering that both of mentioned formatters are backward compatible with > core "gofmt" and that golangci-lint supports enforcing both of them, I'd > like to propose enabling those linters on the repositories. > > I believe this can also resolve some possible discussions on formatting, > saving time and focus on more important areas of the code. > > You can see suggested formatting changes > here: > https://github.com/prometheus/prometheus/commit/282990880615ab698fe9583b21ae52e19c333f46 > > This suggestion was originally posted here: > https://github.com/prometheus/prometheus/issues/9557 > > Let me know what you think. > > Regards, > Mateusz Gozdek
I like this idea. -- Julien Pivotto @roidelapluie -- You received this message because you are subscribed to the Google Groups "Prometheus Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/prometheus-developers/20211021083605.GA130008%40hydrogen.
