On 23 Aug 12:17, Brian Brazil wrote: > On Sun, 23 Aug 2020 at 12:08, Julien Pivotto <[email protected]> > wrote: > > > Dear developers, > > > > Prometheus has an experimental api V2 in GRPC, which does not get any > > updates. In addition, it is marked experimental, so we could drop it in > > minor releases. > > > > The code itself is quite small, there is (to my knowledge) no > > documentation and no tests. > > > > The feature surface seems to be really small, with only admin-specific > > API's implemented. > > > > At this point, I'd like to see if we could remove that code, and also > > the cmux library we use, which did not get any updated in 2 years, and > > is incompatible with recent releases of GRPC. > > > The plan of record is to remove it whenever 3.0 is released, however if > it's causing us hassle I see no issue with removing it sooner.
1. CMUX That cmux library is using the helloworld package from grpc which is gone. https://github.com/soheilhy/cmux/blob/8a8ea3c53959009183d7914522833c1ed8835020/example_test.go#L32 Additionally, the 2.21 fixes some misconfiguration of the cmux that makes prometheus hang on SIGTERM. I hope that the mitigation we have is complete, but the library lacks features like clean shutdown: https://github.com/soheilhy/cmux/issues/39 At the end the repo seems abandoned since 2 years. 2. GRPC We can not update GRPC, partly because of cmux, partly because we are friendly with downstream, cortex, which depends on etcd, which requires an old version of grpc. This is blocking an update of google.golang.org/api, which is used in our GCE discovery. -- Julien Pivotto @roidelapluie -- You received this message because you are subscribed to the Google Groups "Prometheus Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/prometheus-developers/20200823155604.GA235533%40oxygen.
