Ok, thanks. Will do. On Fri, 31 Jul 2020 at 15:16, Ben Kochie <[email protected]> wrote:
> I would start with an issue on the repo. > > On Fri, Jul 31, 2020 at 2:51 PM Danny Smith <[email protected]> > wrote: > >> I've recently had to build node_exporter for an Oracle Solaris system, >> and noticed that the 'Solaris' support is actually currently >> Illumos/OpenIndiana support. Both systems have different sets of ZFS kstat >> information available, and hence the zfs collector doesn't work on Oracle >> Solaris as-is. >> >> I've modified the collector to properly support both flavours, and >> enabled the 'uname' collector (bsd variety) for Solaris/Illumos. I've also >> added a filesystem collector for Solaris/Illumos based on the Linux >> filesystem collector, but using /etc/mnttab instead. I realise this >> strictly breaks the rules, namely 'A Collector may only >> read /proc or /sys files', however under Solaris the kernel mount table is >> mounted via the 'mnttab' FS as /etc/mnttab. >> >> I also had to tweak Makefile.common to enable a build on both systems, as >> by default the build expects to be able to download a 'promu' binary, and >> solaris/illumos are not part of the standard releases. >> >> Could someone take a look please and let me know if this is considered to >> be in a suitable state for a PR? >> >> https://github.com/dsnt02518/node_exporter >> >> Danny >> >> -- >> You received this message because you are subscribed to the Google Groups >> "Prometheus Developers" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/prometheus-developers/de5f4571-2c49-4d89-a2ea-38c110aa8ec9n%40googlegroups.com >> <https://groups.google.com/d/msgid/prometheus-developers/de5f4571-2c49-4d89-a2ea-38c110aa8ec9n%40googlegroups.com?utm_medium=email&utm_source=footer> >> . >> > -- You received this message because you are subscribed to the Google Groups "Prometheus Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/prometheus-developers/CAK-5GyR1-4GtvsPGHYh%3DEDs6SR2n0Vb7EmSaYkCzD19XRB4zLw%40mail.gmail.com.
