>>> Inorder to allow backward compatiblity the functionality >>> of this patch has been done under a macro NEW_POWER_TRACE_APIS. >>> When using a kernel version greater than 2.6.41 uncomment >>> the macro in main.cpp >> >> >> while I don't mind support for the new points... >> >> ... I do mind this being done as a compile time thing with ifdefs. >> >> why not just always support these trace points ? > > I saw code which was using both the old and new version of trace points. In > case of such code, the measurements would be wrong. I can re-submit the patch > without the macros and expect the developers to use any one version of the > trace apis. >
well... trivial to make "add_event" return success/failure, and then we can add the old ones only if the new ones fail _______________________________________________ Power mailing list [email protected] https://bughost.org/mailman/listinfo/power
