On Wed Oct 14, 2020 at 01:55:25PM +0300, Vadim Zhukov wrote:
> ср, 14 окт. 2020 г. в 13:38, Stuart Henderson <s...@spacehopper.org>:
> >
> > On 2020/10/14 09:48, Rafael Sadowski wrote:
> > > On Fri Oct 09, 2020 at 11:49:56PM +0300, Vadim Zhukov wrote:
> > > > Hello all.
> > > >
> > > > Here is a port of the Kid3, a nicely done multimedia tags editor. For
> > > > those who missed TagScanner on OpenBSD for last 15 years — this tool
> > > > might fill your needs, as it did for me.
> > > >
> > > > The utility supports editing multiple MP3, Ogg/Vorbis, FLAC, MPC,
> > > > MP4/AAC, MP2,
> > > > Opus, Speex, TrueAudio, WavPack, WMA, WAV and AIFF files at once,
> > > > having full control over ID3v1 & v2 tags. There are both GUI and
> > > > interactive CLI; I didn't try to use CLI, though, only started it.
> > > >
> > > > Runs fine here on amd64, tests pass 100%.
> > > >
> > > > The port installs two "private" shared libraries under lib/kid3/, I
> > > > preferred to ignore them. The {port-,}lib-depends-check will complain,
> > > > though, not seeing the RUNPATH.
> > > >
> > > > A review/okay/hate/love will be appreciated. :)
> > > > --
> > > > WBR,
> > > > Vadim Zhukov
> > >
> > > Could we remove the following directories, please?
> > >
> > > @mandir share/man/
> > > share/man/ca/
> > > share/man/ca/man1/
> > > share/man/de/
> > > share/man/de/man1/
> > > share/man/it/
> > > share/man/it/man1/
> > > share/man/man1/
> > > share/man/nl/
> > > share/man/nl/man1/
> > > share/man/pt/
> > > share/man/pt/man1/
> > > share/man/sv/
> > > share/man/sv/man1/
> > > share/man/uk/
> > > share/man/uk/man1/
> > > share/metainfo/
> > >
> > > There are some more hints from portcheck:
> > >
> > > - missing RDEP on x11/gtk+3,-guic
> > > - missing RDEP on devel/desktop-file-utils
> > > - the following libraries in WANTLIB look like masked by RUN_DEPENDS:
> > > Qt5Multimedia
> > > - You want add some more x11/qt5/qt* ports to LIB_DEPENDS :)
>
> Yep. Too much time outside process makes you forget some basics. :(
> The fixed version is attached.
>
> > > Otherwise kid3 runs fine here.
> > >
> > > Rafael
> > >
> >
> > those are wrong too:
> >
> > lib/kid3/libkid3-core.so.3.8.4
> > lib/kid3/libkid3-gui.so.3.8.4
>
> Those are "internal" to Kid3 (they live in lib/kid3/, not in lib/),
> and are versioned by mistake. At first glance in CMakeLists.txt this
> will require some patching, so, as I wrote in the original letter, I
> choose to ignore those libs. But if you insist, though, I will fix it,
> of course. :)
>
I would prefer a kid3 port with the following patches and a fresh
updated PLIST. Otherwise OK rsadowski@
$OpenBSD$
Index: src/core/CMakeLists.txt
--- src/core/CMakeLists.txt.orig
+++ src/core/CMakeLists.txt
@@ -175,7 +175,7 @@ target_compile_definitions(kid3-core
PUBLIC QT_ASCII_CAST_WARNINGS QT_NO_CAST_TO_ASCII QT_NO_URL_CAST_FROM_STRING
QT_STRICT_ITERATORS QT_NO_EXCEPTIONS QT_NO_STL
)
-set_target_properties(kid3-core PROPERTIES VERSION ${KID3_VERSION})
+#set_target_properties(kid3-core PROPERTIES VERSION ${KID3_VERSION})
if(CMAKE_VERSION VERSION_GREATER "3.8")
target_compile_features(kid3-core PUBLIC cxx_std_11)
else()
$OpenBSD$
Index: src/gui/CMakeLists.txt
--- src/gui/CMakeLists.txt.orig
+++ src/gui/CMakeLists.txt
@@ -109,7 +109,7 @@ target_include_directories(kid3-gui PRIVATE widgets PU
target_compile_definitions(kid3-gui PRIVATE KID3_BUILD_GUI_LIB)
-set_target_properties(kid3-gui PROPERTIES VERSION ${KID3_VERSION})
+#set_target_properties(kid3-gui PROPERTIES VERSION ${KID3_VERSION})
target_link_libraries(kid3-gui kid3-core Qt5::Widgets Qt5::Multimedia)
if(BUILD_SHARED_LIBS)
