On Sun, Oct 18, 2020 at 2:05 AM Jonathan Gray <j...@jsg.id.au> wrote:
>
> On Sun, Oct 11, 2020 at 01:06:56AM -0400, Daniel Dickman wrote:
> > piglit is a consumer of python2 numpy. because newer versions of numpy are
> > python3-only, the diff below proposes to move piglit from python2 to
> > python3 so numpy can be updated.
> >
> > By moving to python3 we can also get rid of the py-subprocess32
> > dependency.
> >
> > I don't know too much about piglit but I was able to run "piglit run
> > sanity results" on my amd64 box.
> >
> > The one nice thing about moving from py2 to py3 is that "make
> > update-plist" repairs some of the odd substitutions that are in the
> > current PLIST. So a bunch of the PLIST changes below are just due to:
> >
> > "co${MODPY_PY_PREFIX}" -> "copy-"
> >
> > ok?
>
> These changes look fine to me, ok jsg@Thank you Jonathan! I've found my initial attempt needs a fair bit more work actually. For example there is patches/patch-piglit which needs to go as it's forcing use of python2 at the moment and a few other things I've found since I sent the initial attempt. > > we should also handle the lack of libgen.h includes for basename(3) > 'warning: implicit declaration of function 'basename' is invalid in C99 > [-Wimplicit-function-declaration]' > seen with > tests/util/piglit-util.c > tests/util/piglit-framework-gl.c > tests/util/piglit-framework-gl.c > tests/util/piglit-framework-gl.c > tests/egl/spec/egl_chromium_sync_control/egl_chromium_sync_control.c > tests/util/piglit-framework-gl.c > > but that could be a different commit i also did do a fuller update to latest piglit. let me check what i see there and if it may be worth just doing both at the same time. > > There is a warning on python 3.9 I see when building > generated_tests/gen_shader_precision_tests.py:88: DeprecationWarning: Using > or importing the ABCs from 'collections' instead of from 'collections.abc' is > deprecated since Python 3.3, and in 3.9 it will stop working > return isinstance(arg, (collections.Sequence, numpy.ndarray)) > > but we default to 3.8 for now and this would likely be addressed by > updating piglit at some point. either way would work I think. let me go back to the drawing board and come back when I have something better.
