On Sat, Oct 17, 2020 at 09:36:34PM -0400, Ashton Fagg wrote:
> This is a new port for autorandr. This is a simple-ish Python script
> that wraps xrandr and lets you automate xrandr actions as you unplug
> monitors etc.
> 
> Tested on my machine (amd64) running current. Port patches, builds and
> installs successfully. Installed executable runs, `man autorandr` also
> works.
> 
> Checkpatch is clean.
Do you mean portcheck(1)?

> Any feedback greatly appreciated.
Please submit new ports as tarball of the ports directory.

> --- /dev/null
> +++ b/sysutils/autorandr/Makefile
> @@ -0,0 +1,29 @@
> +# $OpenBSD: Makefile,v 1.13 2019/11/10 16:25:41 kmos Exp $
> +
> +COMMENT=             automates xrandr calls based on connect devices
> +
> +MODPY_EGG_VERSION= 1.10.1
You can merge that right into GH_TAGNAME.

> +DISTNAME=            autorandr-${MODPY_EGG_VERSION}
GH_* sets DISTNAME and PKGNAME automatically so only set them manually
when required (not here).

> +CATEGORIES=          sysutils
"x11" could do as second category.

> +
> +GH_ACCOUNT=phillipberndt
> +GH_PROJECT=autorandr
> +GH_TAGNAME=${MODPY_EGG_VERSION}
> +
> +# GPLv3
> +PERMIT_PACKAGE=      Yes
> +
> +MAINTAINER=Ashton Fagg <ash...@fagg.id.au>
> +
> +MODULES=     lang/python
> +MODPY_SETUPTOOLS = Yes
New ports should be using Python 3, i.e.
MODPY_VERSION=  ${MODPY_DEFAULT_VERSION_3}

> --- /dev/null
> +++ b/sysutils/autorandr/patches/patch-autorandr_py
> @@ -0,0 +1,11 @@
> +$OpenBSD$
> +
> +Index: autorandr.py
> +--- autorandr.py.orig
> ++++ autorandr.py
> +@@ -1,4 +1,4 @@
> +-#!/usr/bin/env python
> ++#!/usr/bin/env python2
Use MODPY_ADJ_FILES, see port-modules(5).

> --- /dev/null
> +++ b/sysutils/autorandr/pkg/DESCR
> @@ -0,0 +1 @@
> +Automates xrandr actions.
This is not a description, even COMMENT contains more information.
Please be more elaborate so that `pkg_info autorandr' will tell users
what to expect from this package before they install it.

Reply via email to