Updated tarball attached.

On 2020-10-13 15:54, Stuart Henderson wrote:
> Relating to the port:
> 
> - the various ${PROGNAME} in Makefile are quite awkward, prefer just 'pftbld'

Done.

> 
> - looks like there should be an "@sample ${SYSCONFDIR}/pftbld.conf" after
> the pftbld.conf entry in plist

Done.

> 
> Relating to pftbld itself:
> 
> - tinypfctl.c is a binding to PF ABI. while there are a few other things
> which do this in ports, many of them are broken or have been broken
> for quite long times in the past due to PF changes. I think it's not
> an absolute show-stopper as long as you plan to track OpenBSD -current
> and keep it updated and let us know if REVISION bumps are needed due
> to changes in PF structs (ABI), or make changes as needed for API changes,

Sure thing!

> but generally it's preferred to interface by calling the pfctl(8) binary
> instead, that way it would be decoupled from PF ABI/API.
> 
> 

Attachment: pftbld-0.1.0.tar.gz
Description: GNU Zip compressed data

Reply via email to