On Mon, Oct 12, 2020 at 08:17:25AM +0200, Charlene Wendling wrote: > Hi, > > There are 2 problems with xtermset: > > - EOF is not properly checked on unsigned char archs while loading and > storing the configuration file > - There is a boundary error while saving the configuration file, > leading to a segfault that i can't reproduce on amd64 > > These problems vanish with the below diff, the runtime is fine on amd64 > and macppc. While here i have removed a trailing whitespace in the > Makefile. > > Comments/feedback are welcome,
This one also looks correct. ok tb I would have said "Fix array bounds" instead of "Fix boundary error" in the patch comment. I had to look at the patch itself to understand what the latter meant, but maybe that's just me :)
