On Sun, Oct 11, 2020 at 05:28:56PM +0200, Charlene Wendling wrote: > > xstatbar don't run on my macppc, it just prints out the help summary > and quit when i try to run it without arguments. On amd64, it runs > as expected. > > The problem is similar to the osd_clock one i just reported [0]. > > With the below diff, it runs fine on macppc and amd64. > > Comments/feedback are welcome, > > Charlène. > > > [0] https://marc.info/?l=openbsd-ports&m=160242702704545&w=2 > > > Index: Makefile > =================================================================== > RCS file: /cvs/ports/sysutils/xstatbar/Makefile,v > retrieving revision 1.22 > diff -u -p -u -p -r1.22 Makefile > --- Makefile 16 Apr 2020 06:54:41 -0000 1.22 > +++ Makefile 11 Oct 2020 15:21:28 -0000 > @@ -5,7 +5,7 @@ ONLY_FOR_ARCHS= ${APM_ARCHS} > COMMENT= simple system monitor bar > > DISTNAME= xstatbar-0.5 > -REVISION= 11 > +REVISION= 12 > FIX_EXTRACT_PERMISSIONS=Yes > > CATEGORIES= sysutils x11 > Index: patches/patch-xstatbar_c > =================================================================== > RCS file: /cvs/ports/sysutils/xstatbar/patches/patch-xstatbar_c,v > retrieving revision 1.2 > diff -u -p -u -p -r1.2 patch-xstatbar_c > --- patches/patch-xstatbar_c 1 Jun 2018 14:16:30 -0000 1.2 > +++ patches/patch-xstatbar_c 11 Oct 2020 15:21:28 -0000 > @@ -1,6 +1,20 @@ > +# $OpenBSD$ > + > +Hunk #1: parse properly options on archs where char is unsigned > + by default (arm, ppc) > + > Index: xstatbar.c > --- xstatbar.c.orig > +++ xstatbar.c > +@@ -51,7 +51,7 @@ main (int argc, char *argv[]) > + { > + const char *errstr; > + char *font; > +- char ch; > ++ int ch;
My OCD would appreciate a space in front of ch to align the variables, other than that ok tb > + int x, y, w, h; > + int sleep_seconds; > + > @@ -297,6 +297,7 @@ draw_divider(XColor color, int x, int width) > void > draw() >
