On Sun, Sep 27, 2020 at 08:23:40PM +0100, Stuart Henderson wrote:

> This is the same as many other ports where it picks up and requires
> the header if present but doesn't actually use the backtrace()
> (or in some other ports backtrace_fd) function because it
> only looks for it in libc.

> It is better to neuter the autoconf check rather than add a dep;
> the fewer ports that depend on devel/libexecinfo, the less often it
> will be installed during build, so the less often other ports will
> randomly run into build failures due to this + dpb junking.

> I would be OK with a diff that just added ac_cv_header_execinfo_h=no
> to CONFIGURE_ENV (no need to bump REVISION).

That *does* sound better. :)

How's this?

--Kurt

Index: Makefile
===================================================================
RCS file: /cvs/ports/www/sarg/Makefile,v
retrieving revision 1.30
diff -u -r1.30 Makefile
--- Makefile    12 Jul 2019 20:51:05 -0000      1.30
+++ Makefile    27 Sep 2020 20:09:30 -0000
@@ -24,7 +24,8 @@
                        --enable-sargphp=${VARBASE}/www/htdocs/sarg-php \
                        --enable-fontdir=${SYSCONFDIR}/sarg/fonts \
                        --enable-imagedir=${SYSCONFDIR}/sarg/images
-CONFIGURE_ENV=         CPPFLAGS="-I${X11BASE}/include -I${LOCALBASE}/include" \
+CONFIGURE_ENV=         ac_cv_header_execinfo_h=no \
+                       CPPFLAGS="-I${X11BASE}/include -I${LOCALBASE}/include" \
                        LDFLAGS="-L${X11BASE}/lib -L${LOCALBASE}/lib -liconv 
-lintl"
 
 MODGNU_CONFIG_GUESS_DIRS=${WRKSRC}/cfgaux

Reply via email to