from a quick read-through,

> COMMENT =             Character art facsimile generator

s/Char/char/

> DISTNAME =            chafa-1.4.1
> CATEGORIES =          graphics
> 
> HOMEPAGE =            https://hpjansson.org/chafa/
> 
> MAINTAINER =          Florian Viehweger <open...@out-of-creativity.de>
> 
> # GPLv3

is this GPLv3 only or "GPLv3 or newer" (aka GPLv3+)?

> PERMIT_PACKAGE =      Yes
> 
> WANTLIB +=            ICE MagickCore-6.Q16 MagickWand-6.Q16 SM X11 Xext Xt
> WANTLIB +=            bz2 c djvulibre expat fftw3 fontconfig freetype glib-2.0
> WANTLIB +=            iconv intl jasper jbig jpeg lcms2 lzma m openjp2 pcre
> WANTLIB +=            png pthread raw_r tiff webp webpdemux webpmux xcb xml2
> WANTLIB +=            z zstd
> 
> LIB_DEPENDS =         devel/glib2 \
>                       graphics/ImageMagick
> 
> SHARED_LIBS +=        chafa                     0.0 # 4.0
> 
> MASTER_SITES =                https://hpjansson.org/chafa/releases/
> EXTRACT_SUFX =                .tar.xz

variable ordering is a bit off from Makefile.template, it's easier when
doing whole-tree work if it is closer to it

> COMPILER =            base-clang ports-gcc

does it fail with base-gcc? it's not C++ so the "must use the correct
C++ standard library" reason for setting this doesn't apply.

> AUTOCONF_VERSION =    2.69
> AUTOMAKE_VERSION =    1.15
> CONFIGURE_STYLE =     gnu

AUTO*_VERSION are unused here aren't they?

> post-install:
>       ${INSTALL_MAN} ${WRKSRC}/docs/chafa.1 ${PREFIX}/man/man1
> 
> .include <bsd.port.mk>

Reply via email to