On Thu, Aug 13, 2020 at 10:09:41PM +0200, Charlene Wendling wrote: > Hi, > > Godot does not build in the current macppc bulk with, as seen on i386: > > > ./core/safe_refcount.h:139:7: error: large atomic operation may incur > > significant performance penalty [-Werror,-Watomic-alignment] > > This warning is far from being a rare sight on macppc, with no > noticeable impact. > > This is happening because development C/CXXFLAGS are provided with > "dev=yes". This build option overrides the "werror" one [0], so > "werror=no" won't do the job. > > This builds fine on macppc.
Still builds fine on amd64. I'm ok thfr@ with this diff. Curious if this fixes i386, too. > > Comments/feedback are welcome, > > Charl??ne. > > > [0] https://github.com/godotengine/godot/blob/master/SConstruct#L134 > > > Index: Makefile > =================================================================== > RCS file: /cvs/ports/games/godot/Makefile,v > retrieving revision 1.13 > diff -u -p -u -p -r1.13 Makefile > --- Makefile 3 Aug 2020 18:41:08 -0000 1.13 > +++ Makefile 13 Aug 2020 20:06:13 -0000 > @@ -1,6 +1,5 @@ > # $OpenBSD: Makefile,v 1.13 2020/08/03 18:41:08 thfr Exp $ > > -BROKEN-i386 = core/safe_refcount.h error: misaligned atomic operation > may incur significant performance penalty > COMMENT = 2D and 3D game engine > > V = 3.2.2 > @@ -50,11 +49,13 @@ MODSCONS_FLAGS = CC="${CC}" \ > builtin_pcre2=no \ > builtin_zlib=no \ > builtin_zstd=no \ > - dev=yes \ > platform=x11 \ > progress=no \ > pulseaudio=no \ > - target=release_debug > + target=release_debug \ > + verbose=yes \ > + warnings=extra \ > + werror=no > LIB_DEPENDS = archivers/zstd \ > audio/libvorbis \ > audio/musepack \
