On Thu, Aug 13 2020, Jeremie Courreges-Anglas <j...@wxcvbn.org> wrote:
> libtheoraply fails to build now on i386, I don't have the error message
> at hand but it's about ELF relocations. Shared libraries should be
> linked with -fpic/-fPIC.
>
> ok?
naddy committed a fix using -fPIC which is safe to use on all arches.
(I don't know if ports should use ${PICFLAG} from bsd.own.mk when
practical, but a few ports do it already.)
> Index: Makefile
> ===================================================================
> RCS file: /cvs/ports/multimedia/libtheoraplay/Makefile,v
> retrieving revision 1.4
> diff -u -p -r1.4 Makefile
> --- Makefile 6 Mar 2020 15:24:40 -0000 1.4
> +++ Makefile 13 Aug 2020 21:18:56 -0000
> @@ -8,7 +8,7 @@ HG_COMMIT = fb533bb8633e
> DISTFILES = libtheoraplay-${HG_CHANGESET}{${HG_COMMIT}}${EXTRACT_SUFX}
>
> PKGNAME = libtheoraplay-${HG_CHANGESET}
> -REVISION = 0
> +REVISION = 1
> CATEGORIES = multimedia
> MASTER_SITES = https://hg.icculus.org/icculus/theoraplay/archive/
>
> @@ -39,7 +39,7 @@ NO_TEST = Yes
>
> do-build:
> cd ${WRKSRC} && \
> - ${CC} ${CFLAGS} ${LDFLAGS} -shared -I${LOCALBASE}/include \
> + ${CC} ${PICFLAG} ${CFLAGS} ${LDFLAGS} -shared -I${LOCALBASE}/include \
> -L${LOCALBASE}/lib -lpthread -logg -lvorbis -ltheoradec -o \
> ${WRKBUILD}/libtheoraplay.so.${LIBtheoraplay_VERSION} \
> theoraplay.c
--
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE
